[PATCH] D56933: [Tooling][RFC] Introduce Stencil library to simplify source code generation in refactorings.

[Yitzhak Mandelbaum via Phabricator via cfe-commits]

ymandel updated this revision to Diff 186667.
ymandel added a comment.
Herald added a subscriber: jdoerfert.

Added two example uses of Transformer in clang-tidy.

Specifically, updated readability-delete-null-pointer and readability-else-after-return checks to use Transformer.  In both cases, we do not maintain 100% fidelity with original check.  In particular, Transformer does not preserve whitespace as carefully as those checks were implemented.  We have updated the tests to make clear the differences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56933/new/

https://reviews.llvm.org/D56933

Files:
  clang-tools-extra/clang-tidy/readability/DeleteNullPointerCheck.cpp
  clang-tools-extra/clang-tidy/readability/DeleteNullPointerCheck.h
  clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp
  clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.h
  clang-tools-extra/clang-tidy/utils/CMakeLists.txt
  clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp
  clang-tools-extra/clang-tidy/utils/TransformerTidy.h
  clang-tools-extra/test/clang-tidy/readability-delete-null-pointer.cpp
  clang-tools-extra/test/clang-tidy/readability-else-after-return-if-constexpr.cpp
  clang-tools-extra/test/clang-tidy/readability-else-after-return.cpp
  clang-tools-extra/unittests/clang-tidy/CMakeLists.txt
  clang-tools-extra/unittests/clang-tidy/TransformerTidyTest.cpp
  clang/include/clang/Tooling/Refactoring/Stencil.h
  clang/include/clang/Tooling/Refactoring/Transformer.h
  clang/lib/Tooling/Refactoring/CMakeLists.txt
  clang/lib/Tooling/Refactoring/Stencil.cpp
  clang/lib/Tooling/Refactoring/Transformer.cpp
  clang/unittests/Tooling/CMakeLists.txt
  clang/unittests/Tooling/StencilTest.cpp
  clang/unittests/Tooling/TransformerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56933.186667.patch
Type: text/x-patch
Size: 138494 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190213/4a1cf8d8/attachment-0001.bin>