[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

Wed Feb 13 05:44:32 PST 2019

rengolin added a comment.
Herald added a subscriber: jdoerfert.

Funny thing is, SVML is also only supported, AFAIK, for Intel. I agree that we should emit errors, but we should also emit a similar error on SVML.

I know it's not entirely relevant to this patch, but we should keep the behaviour consistent on all veclibs.

Also, can you add a test for the new error messages, please?

The new changes look good to me and don't substantially deviate from the previous, approved, patch, so LGTM after addressing the comments.

Thanks!

================
Comment at: lib/Frontend/CompilerInvocation.cpp:678
+      else
+        Diags.Report(diag::err_drv_invalid_value) << A->getAsString(Args)
+          << Name;
----------------
This is not really invalid value for the flag, it's invalid architecture for the value.

I think there's already a string for that somewhere in Clang.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53928/new/

https://reviews.llvm.org/D53928