[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

Seems reasonable. LG with a couple of nits. Please let me know if you need to commit this for you.



================
Comment at: D:/Format/llvm/tools/clang/lib/Format/WhitespaceManager.cpp:685
+      Text.append(Spaces, ' ');
+    } else {
+      // Align to next tab.
----------------
nit: I'd just `break` here and remove the `else`.


================
Comment at: D:/Format/llvm/tools/clang/lib/Format/WhitespaceManager.cpp:686
+    } else {
+      // Align to next tab.
       Spaces -= FirstTabWidth;
----------------
nit: "Align to the next tab."


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57655/new/

https://reviews.llvm.org/D57655