[PATCH] D58145: [Sema] Fix a bogus -Wconversion warning

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 12 16:40:00 PST 2019


nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

Thanks for fixing this regression (sorry, I caused it).  Doesn't regress the tests I added.  You'll probably want to request to Hans that this gets picked up for the 8.0 release.  Not sure if @rsmith has comments on the added `fixme`?



================
Comment at: clang/test/SemaObjC/conversion.m:23
+  double local = 42;
+  dp.d += local;
+}
----------------
does this need a `// no-warning` comment?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58145/new/

https://reviews.llvm.org/D58145





More information about the cfe-commits mailing list