efriedma added a comment. This looks essentially fine, but I'd like to see some basic test coverage for the changes to warnings and constant evaluation. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120