[PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 12 04:55:15 PST 2019


thakis added a comment.
Herald added a subscriber: jdoerfert.

I don't have an opinion if this patch here or the assert wrapper is better, but I feel somewhat strongly that we should land one or the other so that the standard C program

  #include <assert.h>
  
  static_assert(4 == 4 , "");

builds in clang-cl like it does in every other compiler.

Sounds like rnk and rsmith are the champions for each approach, so maybe the two of you could have a meeting of the minds somewhere and Decide What To Do Here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D17444/new/

https://reviews.llvm.org/D17444





More information about the cfe-commits mailing list