[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.
Volodymyr Sapsai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 11 19:59:09 PST 2019
vsapsai marked an inline comment as done.
vsapsai added inline comments.
================
Comment at: clang/lib/Lex/HeaderSearch.cpp:388
} else {
Result = HS.getFileMgr().getFile(Dest);
}
----------------
I have considered changing this to `.getFile(Dest, /*OpenFile=*/true)` so that the bug can be triggered without a double include. But decided not to do so because it seems weird to open a file (and make an extra syscall) to make it easier to ignore the filename case mismatch later.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58094/new/
https://reviews.llvm.org/D58094
More information about the cfe-commits
mailing list