[PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

In D57984#1394067 <https://reviews.llvm.org/D57984#1394067>, @ABataev wrote:

> In D57984#1394050 <https://reviews.llvm.org/D57984#1394050>, @rsmith wrote:
>
> > @ABataev Is it intentional that we do not propagate `Allowed` through labels? For example:
> >
> >   void f() {
> >     #pragma omp barrier // ok
> >  
> >   label:
> >     #pragma omp barrier // error, "cannot be an immediate substatement"
> >  
> >   label:
> >     ;
> >     #pragma omp barrier // ok
> >   }
> >
> >
> > ?
>
>
> No, it is a bug.


Great, then I'll unify this new flag with the `Allowed` mechanism and fix the bug as part of this change. Thanks!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57984/new/

https://reviews.llvm.org/D57984