[PATCH] D54978: Move the SMT API to LLVM

[Brian Rzycki via Phabricator via cfe-commits]

brzycki added a comment.

In D54978#1393968 <https://reviews.llvm.org/D54978#1393968>, @thakis wrote:

> Do you understand why the default matters for you? You seem to explicitly disable the setting, and you still get Z3 as part of your build. Did you make a clean build dir before turning it to OFF?


Yes, Please see my recreation instructions above. I created a new, empty `build` directory.

> If so, I don't understand why the default setting is important to you and why this doesn't work for you. (I don't disagree with the default being off, I'm just confused why things don't work for you.)

As I have stated several times, the CMake option `-D LLVM_OPTIMIZED_TABLEGEN=ON` spawns a sub-command of CMake and **is required for the break to occur**. I don't know how to make this any more clear. If you build with optimized tablegen, it breaks. I strongly suspect an interaction between LLVM's top-level CMake and the TableGen one but I haven't had time to debug it down to the exact cause.

It is important to me because the detection of the correct version of Z3 is imprecise, at best.  If a Z3 library is found  I have no way to guarantee a build I run will not attempt to include the library.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54978/new/

https://reviews.llvm.org/D54978