[PATCH] D57991: [Driver][Darwin] Emit an error when using -pg on OS without support for it.

Steven Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 11 11:02:22 PST 2019


steven_wu accepted this revision.
steven_wu added a comment.
This revision is now accepted and ready to land.

LGTM with a suggestion to make code cleaner.



================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:101
+  "the clang compiler does not support -pg option on Darwin">;
+def err_drv_clang_unsupported_opt_pg_darwin_osx: Error<
+  "the clang compiler does not support -pg option on versions of OS X 10.9 and later">;
----------------
Might be cleaner if you use %select here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57991/new/

https://reviews.llvm.org/D57991





More information about the cfe-commits mailing list