[PATCH] D45978: dllexport const variables must have external linkage.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 11 05:27:06 PST 2019


aaron.ballman added a comment.

It looks like the patch got mucked up somehow, I only see three testing files in the patch now?



================
Comment at: test/Sema/dllexport.c:168
+
+// CHECK: @y = common dso_local dllexport global i32 0, align 4
+
----------------
Nothing runs FileCheck in this test, so this isn't checking anything. That should be tested within CodeGen instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45978/new/

https://reviews.llvm.org/D45978





More information about the cfe-commits mailing list