[PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 11 05:04:27 PST 2019


thakis added a comment.

I just ran into this and I'm a bit confused about the discussion here. This snippet (in a .c file)

  #include <assert.h>
  
  static_assert(4 == 4 , "");

builds in all compilers except clang-cl. How does not supporting this make sense?

Instead of this patch we could have an assert.h wrapper in lib/Headers that defines static_assert to _Static_assert in ms mode for C files, and I suppose that's a cleaner fix. But I hope it's not controversial that we should try and support standard C programs?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D17444/new/

https://reviews.llvm.org/D17444





More information about the cfe-commits mailing list