[PATCH] D58037: [clangd] Prefer location from codegen files when merging symbols.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 11 03:29:56 PST 2019


ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

For example, if an index symbol has location in a .proto file and an AST symbol
has location in a generated .proto.h file, then we prefer location in .proto
which is more meaningful to users.

Also use `mergeSymbols` to get the preferred location between AST location and index location in go-to-def.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D58037

Files:
  clangd/XRefs.cpp
  clangd/index/Merge.cpp
  unittests/clangd/IndexTests.cpp
  unittests/clangd/XRefsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58037.186219.patch
Type: text/x-patch
Size: 6619 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190211/e87a560a/attachment.bin>


More information about the cfe-commits mailing list