[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

> You are right. May be it worth disabling `-fix` for `j != 1`.

I only say this because I think I might have seen it happen when I was running `run-clang-tidy.py` over a large code base with a fairly aggressive check/fixit, but frankly I was too new to LLVM to know it wasn't something I might have done wrong.

I saw my '[[nodiscard]]' checker splicing multiple `[[nodiscard]]`s onto the same line, I suspect there is a time of check/time of use issue for the locations, sometimes the positions where wrong by the time the Fixit came around. I guess because i'd used that script without specifiy a `-j1` it just used the default which is `-j0` which I guess goes as parallel as it can.

Its only when you raised this review for the diff check that I wondered if that could be the cause.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57662/new/

https://reviews.llvm.org/D57662