[PATCH] D57896: Variable names rule

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 9 16:39:08 PST 2019


hubert.reinterpretcast added a comment.

In D57896#1391611 <https://reviews.llvm.org/D57896#1391611>, @zturner wrote:

> Is this actually any better?  Whereas before we can’t differentiate type names and variable names, under this proposal we can’t differentiate type names and function names.  So it seems a bit of “6 of 1, half dozen of another”


Perhaps you mistyped? The proposal does not change the status quo of either type names nor function names. If you mean that we can't differentiate variable names and function names, then it seems worthwhile to point out that the actual letters (not just the case of said letters) matter too. Whereas the guidelines state that types and variables should have names that are nouns, the guidelines state that functions should have names that are verb phrases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57896/new/

https://reviews.llvm.org/D57896





More information about the cfe-commits mailing list