[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added inline comments.
Herald added a project: clang.


================
Comment at: clang-tidy/cppcoreguidelines/MixedIntArithmeticCheck.h:1
+//===--- MixedIntArithmeticCheck.h - clang-tidy------------------*- C++ -*-===//
+//
----------------
I guess the license has to be updated


================
Comment at: docs/ReleaseNotes.rst:247
   removal of the ``const`` keyword.
+>>>>>>> master
 
----------------
remove


================
Comment at: docs/clang-tidy/checks/cppcoreguidelines-mixed-int-arithmetic.rst:11
+
+Because of the subtile difference between ``signed`` and ``unsigned`` integer
+types in C++ it is recommended to use ``signed`` types in general for arithmetic
----------------
probably needs running though validate_check.py from { D55523} to make this 80 chars wide


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D40854/new/

https://reviews.llvm.org/D40854