[PATCH] D57874: [WebAssembly] Make thread-related options consistent
Heejin Ahn via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 8 17:53:22 PST 2019
aheejin updated this revision to Diff 186088.
aheejin marked 8 inline comments as done.
aheejin added a comment.
I had an offline discussion with @tlively and @dschuff and decided to remove `-atomics` option in the driver. Instead, `clang -cc1`'s `-target-feature +atomics` will be either of `-pthread` or `-mthread-model posix` is given. This is to reduce the total number of options and thus the total number of combinations of options. Sorry for frequent changes. Also addressed comments.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57874/new/
https://reviews.llvm.org/D57874
Files:
include/clang/Driver/Options.td
include/clang/Driver/ToolChain.h
lib/Driver/Driver.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Driver/ToolChains/WebAssembly.cpp
lib/Driver/ToolChains/WebAssembly.h
test/Driver/wasm-toolchain.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57874.186088.patch
Type: text/x-patch
Size: 7186 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190209/39cc8869/attachment-0001.bin>
More information about the cfe-commits
mailing list