[PATCH] D57874: [WebAssembly] Make thread-related options consistent

Thomas Lively via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 8 13:21:08 PST 2019


tlively added a comment.

In D57874#1389953 <https://reviews.llvm.org/D57874#1389953>, @aheejin wrote:

> - `-matomics` means `-mthread-model posix`


Why should this be the case? Atomic instructions are necessary for multithreading, but I wouldn't think multithreading would be necessary for atomic instructions. Certainly atomics are not very useful in a single threaded context, but that doesn't seem like a strong enough reason to implicitly opt in to the rest of multithreading when -matomics is provided by itself.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57874/new/

https://reviews.llvm.org/D57874





More information about the cfe-commits mailing list