[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

Sjoerd Meijer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 8 05:38:48 PST 2019


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks okay to me, with one nit inline.



================
Comment at: test/Preprocessor/init.c:9169
 // WEBASSEMBLY-NEXT:#define __FLOAT128__ 1
-// WEBASSEMBLY-NEXT:#define __FLT16_DECIMAL_DIG__ 5
-// WEBASSEMBLY-NEXT:#define __FLT16_DENORM_MIN__ 5.9604644775390625e-8F16
----------------
Perhaps change this in WEBASSEMBLY-NOT so that we also have one negative test for this?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57577/new/

https://reviews.llvm.org/D57577





More information about the cfe-commits mailing list