[PATCH] D57874: [WebAssembly] Make thread-related options consistent

Thu Feb 7 17:33:06 PST 2019

sbc100 added a comment.

In D57874#1389981 <https://reviews.llvm.org/D57874#1389981>, @sunfish wrote:

> > - `-matomics` means `-mthread-model posix`
>
> The others sound reasonable, though this one seems a little surprising -- a user might have -matomics enabled because they're targeting a VM that has atomics, but still not want to use -mthread-model posix because their code doesn't actually using threads.

If you look at what "-mthread-model posix" actually means in the codebase it basically means "don't lower away atomics ops".

Its only used by WebAssembly and ARMTargetMachine to select the `createLowerAtomicPass`.   Given that these are the only uses it seems like it should be removed or renamed.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57874/new/

https://reviews.llvm.org/D57874