[PATCH] D54978: Move the SMT API to LLVM

Thu Feb 7 10:31:25 PST 2019

shakeel.mahate added a comment.

The ninja build also fails

ninja -C out/gn
ninja: Entering directory `out/gn'
[1/3182] ACTION //clang/test:lit_site_cfg(//llvm/utils/gn/build/toolchain:unix)
FAILED: gen/clang/test/lit.site.cfg.py 
python ../../llvm/utils/gn/build/write_cmake_config.py -o gen/clang/test/lit.site.cfg.py ../../clang/test/lit.site.cfg.py.in LIT_SITE_CFG_IN_HEADER=\#\#\ Autogenerated\ from\ //clang/test/lit.site.cfg.py.in,\ do\ not\ edit CLANG_BINARY_DIR=/home/shakeel/devel/llvm-project/out/gn/obj/clang CLANG_SOURCE_DIR=/home/shakeel/devel/llvm-project/clang ENABLE_SHARED=0 LLVM_BINARY_DIR=/home/shakeel/devel/llvm-project/out/gn/obj/llvm LLVM_LIBS_DIR= LLVM_SOURCE_DIR=/home/shakeel/devel/llvm-project/llvm LLVM_TOOLS_DIR=/home/shakeel/devel/llvm-project/out/gn/bin TARGET_TRIPLE=x86_64-unknown-linux-gnu SHLIBDIR=/home/shakeel/devel/llvm-project/out/gn/lib CLANG_ANALYZER_WITH_Z3= CLANG_BUILD_EXAMPLES=0 CLANG_DEFAULT_CXX_STDLIB= CLANG_TOOLS_DIR=/home/shakeel/devel/llvm-project/out/gn/bin CMAKE_CXX_COMPILER=c++ ENABLE_BACKTRACES=1 LLVM_HOST_TRIPLE=x86_64-unknown-linux-gnu LLVM_LIT_TOOLS_DIR= LLVM_USE_SANITIZER= PYTHON_EXECUTABLE=python USE_Z3_SOLVER= CLANG_ENABLE_ARCMT=1 CLANG_ENABLE_STATIC_ANALYZER=1 HAVE_LIBZ=1 HOST_ARCH=x86_64 LLVM_PLUGIN_EXT=.so
Traceback (most recent call last):

  File "../../llvm/utils/gn/build/write_cmake_config.py", line 108, in <module>
    sys.exit(main())
  File "../../llvm/utils/gn/build/write_cmake_config.py", line 72, in main
    in_line = var_re.sub(repl, in_line)
  File "../../llvm/utils/gn/build/write_cmake_config.py", line 71, in repl
    return values[key]

KeyError: 'LLVM_WITH_Z3'
[2/3182] ACTION //llvm/include/llvm/Config:config(//llvm/utils/gn/build/toolchain:unix)
FAILED: gen/llvm/include/llvm/Config/config.h 
python ../../llvm/utils/gn/build/write_cmake_config.py -o gen/llvm/include/llvm/Config/config.h ../../llvm/include/llvm/Config/config.h.cmake BUG_REPORT_URL=https://bugs.llvm.org/ ENABLE_BACKTRACES=1 ENABLE_CRASH_OVERRIDES=1 BACKTRACE_HEADER=execinfo.h HAVE_CRASHREPORTERCLIENT_H= HAVE_DECL_FE_ALL_EXCEPT=1 HAVE_DECL_FE_INEXACT=1 LLVM_ENABLE_DIA_SDK= LLVM_ENABLE_CRASH_DUMPS= HAVE_ERRNO_H=1 HAVE_FCNTL_H=1 HAVE_FENV_H=1 HAVE_FFI_CALL= HAVE_FFI_FFI_H= HAVE_FFI_H= HAVE_LIBPFM= HAVE_LIBPSAPI= HAVE_MALLCTL= HAVE_SIGNAL_H=1 HAVE_STD_IS_TRIVIALLY_COPYABLE=1 HAVE_STRERROR=1 HAVE_SYS_STAT_H=1 HAVE_SYS_TYPES_H=1 HAVE_VALGRIND_VALGRIND_H= HAVE__ALLOCA= HAVE___ALLOCA= HAVE___ASHLDI3= HAVE___ASHRDI3= HAVE___CHKSTK= HAVE___CHKSTK_MS= HAVE___CMPDI2= HAVE___DIVDI3= HAVE___FIXDFDI= HAVE___FIXSFDI= HAVE___FLOATDIDF= HAVE___LSHRDI3= HAVE___MAIN= HAVE___MODDI3= HAVE___UDIVDI3= HAVE___UMODDI3= HAVE____CHKSTK= HAVE____CHKSTK_MS= HOST_LINK_VERSION= LLVM_TARGET_TRIPLE_ENV= LLVM_VERSION_INFO= LLVM_VERSION_PRINTER_SHOW_HOST_TARGET_INFO=1 PACKAGE_BUGREPORT=https://bugs.llvm.org/ PACKAGE_NAME=LLVM PACKAGE_STRING=LLVM\ 9.0.0svn PACKAGE_VERSION=9.0.0svn PACKAGE_VENDOR= RETSIGTYPE=void LLVM_GISEL_COV_ENABLED= LLVM_GISEL_COV_PREFIX= LLVM_DEFAULT_TARGET_TRIPLE=x86_64-unknown-linux-gnu HAVE_FUTIMENS=1 HAVE_LINK_H=1 HAVE_LSEEK64=1 HAVE_MALLINFO=1 HAVE_POSIX_FALLOCATE=1 HAVE_SCHED_GETAFFINITY=1 HAVE_CPU_COUNT=1 HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC=1 HAVE_CRASHREPORTER_INFO= HAVE_DECL_ARC4RANDOM= HAVE_DLADDR= HAVE_MACH_MACH_H= HAVE_MALLOC_MALLOC_H= HAVE_MALLOC_ZONE_STATISTICS= HAVE_STRUCT_STAT_ST_MTIMESPEC_TV_NSEC= HAVE_BACKTRACE=1 HAVE_POSIX_SPAWN=1 HAVE_PTHREAD_GETNAME_NP=1 HAVE_DECL_STRERROR_S= HAVE_DLFCN_H=1 HAVE_DLOPEN=1 HAVE_FUTIMES=1 HAVE_GETPAGESIZE=1 HAVE_GETRLIMIT=1 HAVE_GETRUSAGE=1 HAVE_ISATTY=1 HAVE_LIBPTHREAD=1 HAVE_PTHREAD_SETNAME_NP=1 HAVE_LIBZ=1 HAVE_PREAD=1 HAVE_PTHREAD_GETSPECIFIC=1 HAVE_PTHREAD_H=1 HAVE_PTHREAD_MUTEX_LOCK=1 HAVE_PTHREAD_RWLOCK_INIT=1 HAVE_REALPATH=1 HAVE_SBRK=1 HAVE_SETENV=1 HAVE_SETRLIMIT=1 HAVE_SIGALTSTACK=1 HAVE_STRERROR_R=1 HAVE_SYSCONF=1 HAVE_SYS_IOCTL_H=1 HAVE_SYS_MMAN_H=1 HAVE_SYS_PARAM_H=1 HAVE_SYS_RESOURCE_H=1 HAVE_SYS_TIME_H=1 HAVE_TERMIOS_H=1 HAVE_UNISTD_H=1 HAVE_ZLIB_H=1 HAVE__CHSIZE_S= HAVE__UNWIND_BACKTRACE=1 stricmp= strdup= LTDL_SHLIB_EXT=.so HAVE_LIBEDIT= HAVE_LIBXAR= HAVE_TERMINFO= LLVM_ENABLE_ZLIB=1 LLVM_LIBXML2_ENABLED=1
Traceback (most recent call last):

  File "../../llvm/utils/gn/build/write_cmake_config.py", line 108, in <module>
    sys.exit(main())
  File "../../llvm/utils/gn/build/write_cmake_config.py", line 72, in main
    in_line = var_re.sub(repl, in_line)
  File "../../llvm/utils/gn/build/write_cmake_config.py", line 71, in repl
    return values[key]

KeyError: 'LLVM_WITH_Z3'
[3/3182] ACTION //clang/include/clang/Config:Config(//llvm/utils/gn/build/toolchain:unix)
FAILED: gen/clang/include/clang/Config/config.h 
python ../../llvm/utils/gn/build/write_cmake_config.py -o gen/clang/include/clang/Config/config.h ../../clang/include/clang/Config/config.h.cmake BUG_REPORT_URL=https://bugs.llvm.org/ CLANG_DEFAULT_LINKER= CLANG_DEFAULT_STD_C= CLANG_DEFAULT_STD_CXX= CLANG_DEFAULT_CXX_STDLIB= CLANG_DEFAULT_RTLIB= CLANG_DEFAULT_OBJCOPY=objcopy CLANG_DEFAULT_OPENMP_RUNTIME=libomp CLANG_OPENMP_NVPTX_DEFAULT_ARCH=sm_35 CLANG_LIBDIR_SUFFIX= CLANG_RESOURCE_DIR= C_INCLUDE_DIRS= CLANG_CONFIG_FILE_SYSTEM_DIR= CLANG_CONFIG_FILE_USER_DIR= DEFAULT_SYSROOT= GCC_INSTALL_PREFIX= CLANG_ANALYZER_WITH_Z3= BACKEND_PACKAGE_STRING=LLVM\ 9.0.0svn ENABLE_LINKER_BUILD_ID= ENABLE_X86_RELAX_RELOCATIONS= ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER= CLANG_ENABLE_OBJC_REWRITER=1 CLANG_ENABLE_ARCMT=1 CLANG_ENABLE_STATIC_ANALYZER=1 CLANG_HAVE_RLIMITS=1 CLANG_HAVE_LIBXML=1 HOST_LINK_VERSION=
unused values args:

  CLANG_ANALYZER_WITH_Z3

ninja: build stopped: subcommand failed.

In D54978#1389110 <https://reviews.llvm.org/D54978#1389110>, @brzycki wrote:

> This commit is causing a build-break for our nightly cross compilers of arm and aarch64. The immediately preceding commit of D54977 <https://reviews.llvm.org/D54977> does not break with the exact same invocation.
>
> The problem is our build machine (Ubuntu 18.04 LTS) installs an old version of Z3 that is incompatible with LLVM's tip of tree. To deal with this we add `-D CLANG_ANALYZER_ENABLE_Z3_SOLVER=OFF` to force disabling Z3 even if CMake detects the library is installed.
>
>   With this patch I am unable to disable Z3 because `CLANG_ANALYZER_ENABLE_Z3_SOLVER` is no longer in the codebase and setting `-D LLVM_ENABLE_Z3_SOLVER=OFF` still builds Z3 support (which fails):
>
>   [74/187] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Z3Solver.cpp.o
>   FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/Z3Solver.cpp.o
>   /usr/bin/clang++-6.0  -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Support -I/tmp/tmp.UCDOJjmgJ1/src/llvm/lib/Support -I/usr/include/libxml2 -Iinclude -I/tmp/tmp.UCDOJjmgJ1/src/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG    -fno-exceptions -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/Z3Solver.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/Z3Solver.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/Z3Solver.cpp.o -c /tmp/tmp.UCDOJjmgJ1/src/llvm/lib/Support/Z3Solver.cpp
>   /tmp/tmp.UCDOJjmgJ1/src/llvm/lib/Support/Z3Solver.cpp:44:40: error: no matching function for call to 'Z3_get_error_msg'
>                              llvm::Twine(Z3_get_error_msg(Context, Error)));
>                                          ^~~~~~~~~~~~~~~~
>

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54978/new/

https://reviews.llvm.org/D54978