[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

Thu Feb 7 07:23:59 PST 2019

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

In D57879#1388789 <https://reviews.llvm.org/D57879#1388789>, @ilya-biryukov wrote:

> Repro:
>
>   template <class T>
>   struct Foo {};
>  
>   template <template<class> class /*cursor here*/U>
>   struct Foo<U<int>*> {};
>
>
> I'm not sure how easy is that, but this should probably be fixed in the `RecursiveASTVisitor<>`. There's really no point in calling `TraverseDecl(null)`

Ultimately, but the current code has null-checks everywhere except this spot, so I think we should land this first before boiling the ocean.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57879/new/

https://reviews.llvm.org/D57879