[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35
+  const clang::DeclContext *DC = Node.getDeclContext();
+  const clang::FunctionDecl *FD = llvm::dyn_cast<clang::FunctionDecl>(DC);
+  if (!FD)
----------------
lebedev.ri wrote:
> JonasToth wrote:
> > There is `FunctionDecl->castToDeclContext()` which is probably a better fit here.
> I'm guessing you meant `cast*From*DeclContext()`.
> Interesting, that function is never once used.
> And it uses `static_cast<>()`..
I'm not too sure about this.
Given `ParmVarDecl`, are we sure it's `DeclContext` is *always* `FunctionDecl`?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57787/new/

https://reviews.llvm.org/D57787