[PATCH] D57739: [clangd] Format tweak's replacements.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 5 02:37:38 PST 2019
ioeric added inline comments.
================
Comment at: clangd/ClangdServer.cpp:366
+ auto Style = getFormatStyle(Code, File);
+ if (!Style)
+ return;
----------------
hokein wrote:
> not sure the err-handling strategy here -- maybe if this is failed, we still apply replacements (without formatting), rather than stopping.
You should use `getFormatStyleForFile` from SourceCode.h
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57739/new/
https://reviews.llvm.org/D57739
More information about the cfe-commits
mailing list