[PATCH] D57642: [X86] Update clobber list in a test after D57641. Remove filter for 'fpsw' in MS inline asm clobber list generation since the backend now uses 'fpsr'.
Craig Topper via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 4 15:07:17 PST 2019
craig.topper marked an inline comment as done.
craig.topper added inline comments.
================
Comment at: test/CodeGen/ms-inline-asm.c:574
// CHECK: fistp dword ptr $0
-// CHECK: "=*m,*m,~{dirflag},~{fpsr},~{flags}"(i32* %{{.*}}, float* %{{.*}})
+// CHECK: "=*m,*m,~{fpsr},~{dirflag},~{fpsr},~{flags}"(i32* %{{.*}}, float* %{{.*}})
}
----------------
rnk wrote:
> Two fpsr? If we manually add that as an extra constraint, maybe we should remove that logic in this change.
We slap "~{dirflag},~{fpsr},~{flags}" blindly onto both gcc and MS inline assembly. There are tests cases in this file with two ~{flags} as well.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57642/new/
https://reviews.llvm.org/D57642
More information about the cfe-commits
mailing list