[PATCH] D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 4 10:39:36 PST 2019


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang-tidy/abseil/DurationUnnecessaryConversionCheck.cpp:50
+
+  diag(OuterCall->getBeginLoc(), "remove double conversion of absl::Duration")
+      << FixItHint::CreateReplacement(
----------------
also avoid `double` word in the message. 


================
Comment at: docs/clang-tidy/checks/abseil-duration-unnecessary-conversion.rst:17
+
+  // Suggestion - Remove double conversion
+  absl::Duration d2 = d1;
----------------
and here.


================
Comment at: docs/clang-tidy/checks/abseil-duration-unnecessary-conversion.rst:25
+
+  // Suggestion - Remove double conversion
+  absl::Duration d2 = d1;
----------------
and here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57353/new/

https://reviews.llvm.org/D57353





More information about the cfe-commits mailing list