[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 4 06:25:14 PST 2019


aaron.ballman added inline comments.


================
Comment at: lib/Sema/SemaChecking.cpp:11748
+    /// The expressions corresponding to each usage kind.
+    Expr *UsageExprs[UK_Count]{};
+
----------------
You can drop the `{}` here and below.


================
Comment at: lib/Sema/SemaChecking.cpp:11927
+  //
+  // A last thing we have to be careful is that some operation sequences
+  // modification as side effect as well (for example: || or ,). To account for
----------------
A last thing we have to be careful is that -> We also have to be careful that


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57659/new/

https://reviews.llvm.org/D57659





More information about the cfe-commits mailing list