[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

[Nathan Ridge via Phabricator via cfe-commits]

nridge marked 3 inline comments as done.
nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:820
 
+// TODO: Reduce duplication between this function and declToSym().
+static llvm::Optional<TypeHierarchyItem>
----------------
I am open to feedback on whether we want to reduce the duplication between these functions, and if so, suggestions for how.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:901
+
+      // TODO: Populate subtypes.
+    }
----------------
I am deliberately leaving this part for a follow-up patch, as it will require index changes.


================
Comment at: clang-tools-extra/unittests/clangd/Matchers.h:130
 
+// Implements the HasValue(m) matcher for matching an Optional whose
+// value matches matcher m.
----------------
Should I split this out into a separate patch? It's used by the tests being added for this functionality.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56370/new/

https://reviews.llvm.org/D56370