[PATCH] D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width

[Leonard Chan via Phabricator via cfe-commits]

leonardchan added a comment.

In D57553#1380157 <https://reviews.llvm.org/D57553#1380157>, @ebevhan wrote:

> This doesn't seem to address the particular case in the integer conversion patch. In fact, I don't see those conversions at all.


I was initially planning on rebasing and updating the parent patch of this after you took a look at it, but I did not account for the min-max pattern. Incidentally, we can still get the same results without having to change a lot of other tests or existing code if we just add a check for if the source and target have the same width. The saturation test cases these affect are the same as in the previous revision without having to change the other operations and still uses the min-max pattern.

In regards to solving the problem of resizing for int conversions, I'm starting to think that we will need that initial resize since if we want to retain the min-max pattern for all conversions, then it would be necessary to extend and shift when converting from an int to fixed point. Otherwise, I think we'd have the initial pattern I proposed where we check against the source value, but not have this pattern.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57553/new/

https://reviews.llvm.org/D57553