[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 1 06:15:36 PST 2019


ilya-biryukov added a comment.

The change looks reasonable to me, given that you can change the default language version via a build argument.
I don't have the required experience with the lit-tests to give proper approval, though, would wait for someone more relevant to do this.

Do have a comment, though. Any, reason to use `-std=gnu++14` and not `-std=c++14`?
Most (all?) of the tests do not seem to have anything to do with the gnu extensions, so why enable them?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57581/new/

https://reviews.llvm.org/D57581





More information about the cfe-commits mailing list