[PATCH] D57325: [clangd] Collect macros in static index.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 31 21:08:57 PST 2019


sammccall added a comment.
Herald added a project: clang.

So I'm not sure this is actually going to be a win.

When building google's big static index, we index these symbols and then throw most of them away (a high usage threshold applies).
But there's no mechanism here to do that.
If we do index *all* of these, how often are they going to be good vs bad results?

Is there a motivating case for the sorts of macros you are missing?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57325/new/

https://reviews.llvm.org/D57325





More information about the cfe-commits mailing list