[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

Leonard Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 31 14:38:10 PST 2019


leonardchan added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444
   case BO_NE:
+    return Builder.CreateICmpNE(FullLHS, FullRHS);
+  case BO_Mul:
----------------
rjmccall wrote:
> Are padding bits guaranteed zero or unspecified?  Or are we just not really supporting padding bits all the way to IRGen at this time?
I believe the consensus was leaving them unspecified, so operations that can cause overflow into them would result in undefined behavior.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57219/new/

https://reviews.llvm.org/D57219





More information about the cfe-commits mailing list