[PATCH] D57509: [clangd] Append "(fix available)" to diagnostic message when fixes are present.

Thu Jan 31 10:59:07 PST 2019

ilya-biryukov added a comment.

> I don't think it's pure noise. Vscode displays diagnostics in the "PROBLEMS" tab. A suffix allows you to tell whether fixes are available without hovering on the errors.

And it shows bulb icons when you hover over diagnostics in this dialog too. To be clear, it's my personal preference to not have it, that's the reason I call it 'noise', others might like the message and it feel more useful to them.

In D57509#1379003 <https://reviews.llvm.org/D57509#1379003>, @sammccall wrote:

> But this seems pretty minor either way.

Sure :(

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57509/new/

https://reviews.llvm.org/D57509