[PATCH] D57524: Fix ICE on attempt to add an addr space qual to a type qualified by an addr space

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: lib/Sema/SemaInit.cpp:4693
+        T2Quals.addAddressSpace(AS2);
+      QualType WithAScv1T4 = S.Context.getQualifiedType(IgnoreAScv2T2, T1Quals);
+      Sequence.AddQualificationConversionStep(WithAScv1T4, ValueKind);
----------------
`Qualifiers::addQualifiers` should let you do this in a single step.  Also, you seem to be modifying `T2Quals` here after the last use of it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57524/new/

https://reviews.llvm.org/D57524