[PATCH] D52339: Support enums with a fixed underlying type in all language modes

Wed Jan 30 13:14:40 PST 2019

erik.pilkington added a comment.

In D52339#1377527 <https://reviews.llvm.org/D52339#1377527>, @arphaman wrote:

> @erik.pilkington the change to make `objc_fixed_enum` true in non-ObjC mode turned out to be problematic for our adoption. Could you please fix it before LLVM8 is wrapped up so that we don't ship this extension as on by default for all language modes?

Yeah, now that I look again, we shouldn't be changing the FEATURE(...) flag behaviour, because fixed enums in C aren't a formal language feature. I removed this in r352672.

In D52339#1377536 <https://reviews.llvm.org/D52339#1377536>, @arphaman wrote:

> We could introduce a new extension flag like `c_fixed_enum` that can be set for all language modes. `objc_fixed_enum` should apply to ObjC only.

Can't we just use cxx_fixed_enum?

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52339/new/

https://reviews.llvm.org/D52339