[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

Wed Jan 30 13:05:21 PST 2019

baloghadamsoftware added a comment.

In D57100#1373440 <https://reviews.llvm.org/D57100#1373440>, @JonasToth wrote:

> @baloghadamsoftware Do you see any problems with the refactoring, especially the new `FunctionDecl*`-Caching is not exactly a refactoring. If you have any thoughts on that would be great to hear!

Yes, it looks a good improvement, I expect another huge speedup. (We had a previous huge speedup after I optimized the matcher expression in 7.0.1 because in 7.0.0 it seemed to hang, it was really bad).

================
Comment at: clang-tidy/utils/ExceptionAnalyzer.h:23
+/// It can be configured to ignore some exception types, especially
+/// `std::bad_alloc` can be disabled as using dynamic memory will always
+/// give the possibility of an exception.
----------------
`std::bad_alloc` is hardwired to ignore, so I think this comment should be rephrased.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57100/new/

https://reviews.llvm.org/D57100