[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.
Paul Robinson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 30 09:13:39 PST 2019
probinson added inline comments.
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4235
CGM.getContext().getTargetAddressSpace(D->getType());
+ if (CGM.getLangOpts().CUDA && CGM.getLangOpts().CUDAIsDevice) {
+ if (D->hasAttr<CUDASharedAttr>())
----------------
Can a variable have one of these CUDA attributes when CUDAIsDevice is false? I'm just wondering if the extra level of checking is really necessary or useful.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57162/new/
https://reviews.llvm.org/D57162
More information about the cfe-commits
mailing list