[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

Julian Lettner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 29 13:59:07 PST 2019


yln updated this revision to Diff 184168.
yln added a comment.

Directly insert calls to `__asan_handle_no_return`

Clang-CodeGen now directly insert calls to `__asan_handle_no_return`
when a call to a noreturn function is encountered and both UBsan
unreachable and ASan are enabled. This allows UBSan to continue
removing the noreturn attribute from functions without any changes to
the ASan pass.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57278/new/

https://reviews.llvm.org/D57278

Files:
  clang/lib/CodeGen/CGCall.cpp
  clang/lib/CodeGen/CodeGenFunction.h
  clang/test/CodeGen/ubsan-asan-noreturn.c
  clang/test/CodeGenCXX/ubsan-unreachable.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57278.184168.patch
Type: text/x-patch
Size: 6572 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190129/ca744caf/attachment.bin>


More information about the cfe-commits mailing list