[PATCH] D57330: Adjust documentation for git migration.

Pavel Labath via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 29 01:34:09 PST 2019


labath added a comment.

I am not sure we should be recommending to people to place the build folder under the llvm-project checkout. Is that how people use the monorepo build nowadays? This is not an full out-of-source build, since the build folder is still a subfolder of the repo root (and without a .gitignore file containing the right build folder name, git will complain about untracked files in the repository)...



================
Comment at: libcxxabi/www/index.html:86
   <li><code>mkdir build && cd build</code></li>
-  <li><code>cmake .. # on linux you may need to prefix with CC=clang CXX=clang++</code></li>
+  <li><code>cmake -DLLVM_ENABLE_PROJECTS=libcxxabi ../llvm # on linux you may need to prefix with CC=clang CXX=clang++</code></li>
   <li><code>make</code></li>
----------------
mehdi_amini wrote:
> Do you now if prefixing with CC is equivalent to -DCMAKE_C_COMPILER?
It usually is, but it can differ once you start using cache and toolchain files. In any case, using -DCMAKE_C(XX)_COMPILER is the preferred way to do things in cmake.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57330/new/

https://reviews.llvm.org/D57330





More information about the cfe-commits mailing list