[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

Mon Jan 28 19:12:05 PST 2019

rjmccall added a comment.

In D57188#1374890 <https://reviews.llvm.org/D57188#1374890>, @yaxunl wrote:

> This change causes regressions for CUDA/HIP. As single-source language, CUDA/HIP code contains both device and host code. It has separate compilation for host and device.
>  In host compilation, device function is parsed but not emitted in IR. The device function may have _Float16 argument, which is fine if device target supports it. Host compilation
>  should not diagnose use of _Float16 in device functions. However, current implementation diagnose any _Float16 usage in host compilation.

Can this be reasonably delayed using the existing diagnostic-delay mechanism, or is there a problem where the diagnostics aren't necessarily bound to a function definition?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57188/new/

https://reviews.llvm.org/D57188