[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 28 13:27:49 PST 2019
Eugene.Zelenko added inline comments.
================
Comment at: clang-tidy/abseil/DurationDoubleConversionCheck.cpp:48
+
+ if (!isNotInMacro(Result, OuterCall)) return;
+
----------------
Please run Clang-format.
================
Comment at: docs/ReleaseNotes.rst:85
+
+ Find and fix cases where `absl::Duration` values are being converted to
+ numeric types and back again.
----------------
Finds and fixes. Please use `` for language constructs. Same in documentation.
================
Comment at: docs/clang-tidy/checks/abseil-duration-double-conversion.rst:20
+
+
+ // Original - Conversion to integer and back again
----------------
Unnecessary empty line.
================
Comment at: docs/clang-tidy/checks/abseil-duration-double-conversion.rst:27
+ absl::Duration d2 = d1;
+
+
----------------
Unnecessary empty line.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57353/new/
https://reviews.llvm.org/D57353
More information about the cfe-commits
mailing list