[PATCH] D53329: Generate DIFile with main program if source is not available

Mon Jan 28 12:51:11 PST 2019

dblaikie added a comment.

In D53329#1373799 <https://reviews.llvm.org/D53329#1373799>, @yonghong-song wrote:

> @dblaikie As I mentioned in one of my earlier comments, after some analysis, I think this patch definitely not the right way to fix the problem. We just cannot default to the main file if the DIFile source is not available.
>
> I have a bug filed for the same issue (https://bugs.llvm.org/show_bug.cgi?id=40170) Maybe I should close this patch and put the information on the bug report. Do you agree?

Ah, I understand now - thanks for explaining. Yeah, if you feel like this patch isn't the right direction, please mark it "abandoned" & if you're not sure how to proceed, probably worth having some discussion on the bug or in an llvm-dev thread. (or if you're not sure you have the bandwidth to continue - yeah, documenting in the bug anything we've learned so you/someone else can pick it up another time would be great)

Thanks!

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53329/new/

https://reviews.llvm.org/D53329