[PATCH] D56936: Fix handling of overriden methods during ASTImport

[Raphael Isemann via Phabricator via cfe-commits]

teemperor accepted this revision.
teemperor added a comment.

LGTM, thanks!



================
Comment at: unittests/AST/ASTImporterTest.cpp:2271
+    struct D:B { void f(){}; };
+  )";
+  auto BFP =
----------------
I think this should be formatted in the same way as the snippet above.


================
Comment at: unittests/AST/ASTImporterTest.cpp:2344
+  // Check that the redecl chain is intact.
+  EXPECT_EQ(ToBFOutOfClass->getPreviousDecl(), ToBFInClass);
+}
----------------
I'm actually wondering if we should do a full redecl chain check in the ASTImporter tests. E.g. iterating from the most recent decl and just make sure our redecl chain invariants are met (first one returns null and all getMostRecentDecl() calls returns the same decl). i assume usually this is implicitly done when we code gen or so, but this doesn't happen in the ASTImporter tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56936/new/

https://reviews.llvm.org/D56936