[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

In D57127#1371563 <https://reviews.llvm.org/D57127#1371563>, @george.karpenkov wrote:

> > Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by the compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only used by tooling-like things (static analyzer, arcmigrate).
>
> Not only, it has utilities used by the static analyzer which are too generic to be in the static analyzer itself - ProgramPoint.cpp, BodyFarm.cpp, CocoaConventions.cpp to name a few.


ProgramPoint.cpp and BodyFarm.cpp are used by StaticAnalyzer/Core, which the compiler itself uses for CFG-based warnings. Sema also uses CocoaConventions.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57127/new/

https://reviews.llvm.org/D57127