[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from some possible minor nits. Thank you for working on this!



================
Comment at: include/clang/AST/Expr.h:5122
+    AssociationIteratorTy() = default;
+    AssociationTy<Const> operator*() const {
+      return AssociationTy<Const>(cast<Expr>(*E), *TSI,
----------------
Can this continue to return `reference` instead of the concrete type? (Same in the cast expression.)


================
Comment at: include/clang/AST/Expr.h:5126
+    }
+    AssociationTy<Const> operator->() const { return **this; }
+    using BaseTy::operator++;
----------------
Can this return `pointer` instead?


================
Comment at: include/clang/AST/Expr.h:5254
+                            /*Offset=*/NumAssocs, ResultIndex);
+    return {Begin, End};
   }
----------------
If you like being explicit, you could use `llvm::make_range()` here, but I don't insist. Same below.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57106/new/

https://reviews.llvm.org/D57106