[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

[Jonas Toth via Phabricator via cfe-commits]

JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.

LGTM with the few language nits.
The new matchers look better and are more matcher style, gj :)



================
Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:126
+  // Don't register the check if OpenMP is not enabled; the OpenMP pragmas are
+  // completely ignored then, so no OpenMP entires will be present in the AST.
+  if (!getLangOpts().OpenMP)
----------------
typo, entries


================
Comment at: docs/clang-tidy/checks/openmp-use-default-none.rst:10
+
+Using ``default(none)`` clause forces developers to explicitly specify data
+sharing attributes for the variables referenced in the construct,
----------------
Using the


================
Comment at: docs/clang-tidy/checks/openmp-use-default-none.rst:14
+data sharing attribute, thus increasing readability and possibly making errors
+more easier to spot.
+
----------------
making errors easier to spot. the more is not necessary.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57113/new/

https://reviews.llvm.org/D57113