[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

Sat Jan 26 06:23:57 PST 2019

Szelethus added a comment.

In D55424#1364696 <https://reviews.llvm.org/D55424#1364696>, @Szelethus wrote:

> In D55424#1326397 <https://reviews.llvm.org/D55424#1326397>, @NoQ wrote:
>
> > Should we also pass `CheckerManager` into `shouldRegister...`? Or is it entirely useless?
>
>
> I wouldn't say useless, but I'm struggling to come up with an example where registering would depend on non-language dependent reasons. I'm stuck on rebasing my patches, so I'll give it a thought whether it's worth the chore to change everything (but where I'd like to leave a system for the long term, doing extra work shouldn't be a major concern).

For now, I decided against it just to make progress with the project, but if the need arises, I'll be happy to change it.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55424/new/

https://reviews.llvm.org/D55424