[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai marked 2 inline comments as done.
vsapsai added inline comments.


================
Comment at: clang/include/clang/Lex/DirectoryLookup.h:175
+  /// \param [out] IsFrameworkFound For a framework directory set to true if
+  /// specified '.framework' directory is found.
+  ///
----------------
jkorous wrote:
> We might make this easier to understand by explaining where/how the '.framework' directory is specified.
This is a method in `DirectoryLookup` which has a method `isFramework` and constructor parameter `isFramework`. I think at this point users of `DirectoryLookup` should be aware of framework-style header lookup and this is not the right place to describe it.


================
Comment at: clang/include/clang/Lex/HeaderSearch.h:396
+  /// \param IsFrameworkFound If non-null, will be set to true for a framework
+  /// include and if corresponding '.framework' directory was found. Doesn't
+  /// guarantee the requested file is found.
----------------
jkorous wrote:
> We might try to explain what exactly is meant by corresponding .framework directory.
Tweaked the comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56561/new/

https://reviews.llvm.org/D56561