[PATCH] D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 25 18:34:37 PST 2019


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Cool!

I guess we still need to think how exactly do we want to resolve conflicts between dependencies.



================
Comment at: include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:152
 
+  // FIXME: This *really* should be added to the frontend flag descriptions.
   /// Initializes a CheckerManager by calling the initialization functions for
----------------
Indeed! And, which is probably even more important, to `scan-build`'s help (assuming that the respective flags of `scan-build` do actually work in a similar manner).


================
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:143
+  // Would it be better to name it '~experimental' or something else
+  // that's ASCIIbetically last?
+  llvm::sort(Checkers, checkerNameLT);
----------------
I learned a new word today :) :)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56989/new/

https://reviews.llvm.org/D56989





More information about the cfe-commits mailing list