[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno created this revision.
riccibruno added a reviewer: aaron.ballman.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.

Now that the implementation of all of the `Expr::Ignore*` is in `Expr.cpp` we can try to remove some duplication. Do this by separating the logic of the `Expr::Ignore*` from the iterative loop.

This is NFC, except for one change: `IgnoreParenImpCasts` now skips, among other things, everything that `IgnoreImpCasts` skips. This means `FullExpr` are now skipped by `IgnoreParenImpCasts`. This was likely an oversight when `FullExpr` was added to the nodes skipped by `IgnoreParenImpCasts`.


Repository:
  rC Clang

https://reviews.llvm.org/D57267

Files:
  include/clang/AST/Expr.h
  lib/AST/Expr.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57267.183650.patch
Type: text/x-patch
Size: 12965 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190126/acdd77cf/attachment-0001.bin>